Forward OAuth client metadata URL in Rust sessions - #2258
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds Rust SDK support for forwarding OAuth client metadata URLs during session creation and resume.
Changes:
- Adds optional configuration fields and builders.
- Serializes the value in create/resume wire payloads while omitting
None. - Adds serialization coverage for configured values.
Show a summary per file
| File | Description |
|---|---|
rust/src/wire.rs |
Adds optional camelCase wire fields. |
rust/src/types.rs |
Exposes, forwards, and tests the new setting. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f531cfac-d107-4676-963c-a6c10cc92148
Retain OAuth client metadata URL forwarding in create and resume payloads, including custom Debug output. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f531cfac-d107-4676-963c-a6c10cc92148
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 716e07c8-226b-4a6f-beb0-877ccee1eb6e
…lient-metadata-url
…lient-metadata-url
Document that external SDK users remain generic and isolated unless they explicitly provide a host client metadata URL, including on resume. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 716e07c8-226b-4a6f-beb0-877ccee1eb6e
|
Thanks for adding this to the Rust SDK — the implementation is clean and follows the existing optional-field pattern well (builder method, correct Per our contribution guidelines, features need to land consistently across all supported SDKs rather than in a single language, so this shouldn't merge Rust-only. Could you also expose and forward For coverage, please add create/resume wire-serialization unit tests per language (mirroring the Rust test here), and only add E2E coverage where the runtime dependency ( Once parity across languages and per-language tests are in place, please mark this ready for review again and we'll take another look. Thanks again for driving this! |
Summary
authClientIdMetadataUrlsession setting in the Rust SDKsession.createandsession.resumeDependencies
This dependency is needed by the GitHub Copilot desktop app consumer slice. Runtime #14687 must be available for the value to affect MCP OAuth; older runtimes ignore the additive optional request field. The PR remains draft until desktop metadata hosting is live.
Validation
cargo test --all-features auth_client_id_metadata_url_reaches_create_and_resume_wire_payloadscargo +nightly-2026-04-14 fmt --checkcargo clippy --all-features --all-targets -- -D warningscargo test --all-features